stillalex commented on code in PR #1856:
URL: https://github.com/apache/solr/pull/1856#discussion_r1316231711
##########
solr/core/src/java/org/apache/solr/util/tracing/TraceUtils.java:
##########
@@ -158,9 +158,10 @@ public static Span startHttpRequestSpan(HttpServletRequest
request, Context cont
return spanBuilder.startSpan();
}
- public static Span newInterNodeCommunicationSpan(String name) {
+ public static Span newInterNodeCommunicationSpan(String name, String
collection) {
Tracer tracer = TraceUtils.getGlobalTracer();
- SpanBuilder spanBuilder =
tracer.spanBuilder(name).setSpanKind(SpanKind.SERVER);
+ SpanBuilder spanBuilder =
+
tracer.spanBuilder(name).setSpanKind(SpanKind.PRODUCER).setAttribute(TAG_DB,
collection);
Review Comment:
I don't disagree and will change to CONSUMER type. both feel awkward to me
and I was leaning towards producer because that somehow felt better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
