gerlowskija commented on code in PR #2470: URL: https://github.com/apache/solr/pull/2470#discussion_r1608034094
########## solr/api/src/java/org/apache/solr/client/api/endpoint/ClusterFileStoreApis.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.client.api.endpoint; + +import io.swagger.v3.oas.annotations.Operation; +import io.swagger.v3.oas.annotations.Parameter; +import io.swagger.v3.oas.annotations.parameters.RequestBody; +import jakarta.ws.rs.DELETE; +import jakarta.ws.rs.PUT; +import jakarta.ws.rs.Path; +import jakarta.ws.rs.PathParam; +import jakarta.ws.rs.QueryParam; +import java.io.InputStream; +import java.util.List; +import org.apache.solr.client.api.model.SolrJerseyResponse; +import org.apache.solr.client.api.model.UploadToFileStoreResponse; + +@Path("/cluster") +public interface ClusterFileStoreApis { + // TODO Better understand the purpose of the 'sig' parameter and improve docs here. + @PUT + @Operation( + summary = "Upload a file to the filestore.", + tags = {"file-store"}) + @Path("/files{filePath:.+}") + UploadToFileStoreResponse uploadFile( + @Parameter(description = "File store path") @PathParam("filePath") String filePath, + @Parameter(description = "Signature(s) for the file being uploaded") @QueryParam("sig") Review Comment: Probably, or `signatures` - but I'm going to avoid cosmetic changes to the API (in this PR) as making those would drag in changes to other places the API is called. I do aim to update those spots (to remove GenericSolrRequest usage, as we've discussed), just not trying to do it in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
