epugh commented on PR #2470: URL: https://github.com/apache/solr/pull/2470#issuecomment-2130102058
> > If DistribFileStore is the lone implementation of FileStore, then do we need FileStore? > > I suspect the intention was that having an interface leaves the door open to adding a Solr-standalone filestore implementation at some point if someone is motivated enough. > > I don't feel strongly on whether the interface remains or not. Maybe that's worth cleaning up at some point, but IMO it's not necessary here since this PR isn't changing anything about how the FileStore is implemented, just some APIs around it. Assuming we do it as a seperate JIRA, what do you think of renaming DistribFileStore to FileStore and removing the interface? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
