epugh commented on code in PR #2470:
URL: https://github.com/apache/solr/pull/2470#discussion_r1608058108
##########
solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java:
##########
@@ -634,7 +635,7 @@ public Map<String, byte[]> getKeys() throws IOException {
// reads local keys file
private static Map<String, byte[]> _getKeys(Path solrHome) throws
IOException {
Map<String, byte[]> result = new HashMap<>();
- Path keysDir = _getRealPath(FileStoreAPI.KEYS_DIR, solrHome);
+ Path keysDir = _getRealPath(ClusterFileStore.KEYS_DIR, solrHome);
Review Comment:
Was it "errorprone" that we used to help us clean up our code and enforce
some conventions? For another JIRA, see if errorprone would flag any "_"
methods for example. We *do* need to make all our conventions enforced via
automated check, there are too many people over too many years to otherwise
keep code standards intact...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
