iamsanjay commented on PR #2689: URL: https://github.com/apache/solr/pull/2689#issuecomment-2377485484
Of course I am not suggesting this change for now. But still want to share my concern here. The ability to add a listener factory after initialization introduces the potential for a race condition. Currently, both HttpSolrClientProvider and UpdateShardHandler call setSecurityBuilder later in the process, which delays object creation. If any other class recreates the client during this time, it won't be in a complete state, as it will be missing the security listeners. It would be beneficial to incorporate pkiAuthenticationSecurityBuilder into the previously stated Solr client providers ctora and make it available to Http2SolrClient during construction, rather than at a later stage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
