dsmiley commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1766878358
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -2563,6 +2581,11 @@ public PlacementPluginFactory<? extends
PlacementPluginConfig> getPlacementPlugi
return this.distributedCollectionCommandRunner;
}
+ /** Returns default http solr client. */
+ public SolrClient getDefaultHttpClient() {
Review Comment:
_If need be_ we can create an interface like `HttpSolrClient` (we have 3
impls) but the only backend impl we care about is Http2SolrClient (jetty) and
I'm skeptical we're going to see another migration.
BTW sorry but a no-op/empty requestAsync would be nasty... think of it: You
call a method and it does absolutely nothing when it should have issues the
request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
