iamsanjay commented on code in PR #2689: URL: https://github.com/apache/solr/pull/2689#discussion_r1774390477
########## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ########## @@ -2563,6 +2581,11 @@ public PlacementPluginFactory<? extends PlacementPluginConfig> getPlacementPlugi return this.distributedCollectionCommandRunner; } + /** Returns default http solr client. */ + public SolrClient getDefaultHttpClient() { Review Comment: I got it! That is ugly. Anyways I am okay with this method returning Http2SolrClient. @gerlowskija I already worked on changing it for two files PKIAuth and ReindexCollectionCmd, however we decided not to in this one and deal in separate PR. Take a look at this one, If everything's looking good then I will merge this one first and then I will make another. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org