gerlowskija commented on code in PR #2689: URL: https://github.com/apache/solr/pull/2689#discussion_r1775285594
########## solr/core/src/java/org/apache/solr/core/HttpSolrClientProvider.java: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.core; + +import java.lang.invoke.MethodHandles; +import java.util.List; +import java.util.concurrent.TimeUnit; +import org.apache.solr.client.solrj.impl.Http2SolrClient; +import org.apache.solr.common.util.IOUtils; +import org.apache.solr.metrics.SolrMetricManager; +import org.apache.solr.metrics.SolrMetricsContext; +import org.apache.solr.security.HttpClientBuilderPlugin; +import org.apache.solr.update.UpdateShardHandlerConfig; +import org.apache.solr.util.stats.InstrumentedHttpListenerFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Provider of the default SolrClient implementation. + * + * @lucene.internal + */ +class HttpSolrClientProvider { Review Comment: [Q] Should this class declare that it implements `Closeable` or `AutoCloseable` so that it can be used with utilities that expect those interfaces? [Q] I assume you're using package-private scoping here intentionally? Is that because the ctor relies on a class (`UpdateShardHandlerConfig`) that we'd rather not see spread further throughout the codebase? Or some other reason? ########## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ########## @@ -2563,6 +2577,11 @@ public PlacementPluginFactory<? extends PlacementPluginConfig> getPlacementPlugi return this.distributedCollectionCommandRunner; } + /** Returns default http solr client. */ Review Comment: [Q] Could we rename this method to clarify that it returns a SolrClient, and not a "http client". I could imagine the current name confusing readers who are familiar with `UpdateShardHnadler.getDefaultHttpClient` (which returns an apache HttpClient instance). [-0] Would you be willing to add some Javadocs on this method clarifying whether or not callers are responsible for closing the returned instance? [-1] I'm surprised that this method doesn't take a "baseUrl" in some fashion. This is probably the aspect of the PR I probably feel strongest about. Admittedly it's a tricky one to get right given the state of SOLR-17256, the patchy support for URL-overriding among different client implementations, etc. Will raise this at the PR-overview level so it doesn't get buried or lost in the hurly-burly of other inline comments. ########## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ########## @@ -1224,6 +1230,11 @@ private void reloadSecurityProperties() { initializeAuditloggerPlugin((Map<String, Object>) securityConfig.getData().get("auditlogging")); } + private SolrClient createDefaultHttpSolrClient() { Review Comment: [Q] This doesn't appear to be used - should it be removed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
