sijuv commented on PR #2960: URL: https://github.com/apache/solr/pull/2960#issuecomment-2704533403
In the current implementation, the _EarlyTerminatingCollector_ is not used in any code path. The collector is instantiated at only one place https://github.com/apache/solr/blob/ac3d349dac530cf1001d5113fc21b0fd641cc9d5/solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java#L293 . Now this is done only if _getTerminateEarly()_ returns true. It will never return true since the setter is never invoked in any code path. I think @gus-asf mentioned that as well, It is an unused method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
