epugh commented on code in PR #3312: URL: https://github.com/apache/solr/pull/3312#discussion_r2284827259
########## solr/bin/solr.in.sh: ########## @@ -248,14 +248,14 @@ #SOLR_SECURITY_MANAGER_ENABLED=true # This variable provides you with the option to disable the Admin UI. If you uncomment the variable below and -# change the value to true. The option is configured as a system property as defined in SOLR_START_OPTS in the start +# change the value to false. The option is configured as a system property as defined in SOLR_START_OPTS in the start # scripts. -# SOLR_ADMIN_UI_DISABLED=false +# SOLR_UI_ENABLED=false Review Comment: do you mean you prefer the _DISABLED versus teh _ENABLED naming? AS in `SOLR_UI_DISABLED=true`? I was thinking that instead of a mishmash of _ENABLED and _DISABLED, we would always end in _ENABLED and they you would specifiy a true or false... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
