dsmiley commented on code in PR #3312:
URL: https://github.com/apache/solr/pull/3312#discussion_r2286671327
##########
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##########
@@ -248,7 +248,7 @@ public static NodeConfig loadNodeConfig(Path solrHome,
Properties nodeProperties
// ZkFailoverTest test case...
String zkHost = nodeProperties.getProperty(SolrXmlConfig.ZK_HOST);
if (StrUtils.isNotNullOrEmpty(zkHost)) {
- int startUpZkTimeOut = 1000 * Integer.getInteger("waitForZk", 0);
+ int startUpZkTimeOut = 1000 * Integer.getInteger("solr.wait.for.zk", 0);
Review Comment:
This one is in bin/solr and I recall discussing this setting with colleagues
once. Let's not assume it's only for tests just because you only see a test
flip the value in the code. There's no telling what users do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
