epugh commented on code in PR #3312: URL: https://github.com/apache/solr/pull/3312#discussion_r2284846543
########## solr/solrj/src/resources/EnvToSyspropMappings.properties: ########## @@ -5,29 +5,21 @@ # This way, env SOLR_FOO_BAR will also match property 'solr.foo.bar' without a mapping in this file # TODO: Deprecate non-standard sysprops and standardize on solr.foo.bar in Solr 10 AWS_PROFILE=aws.profile -DEFAULT_CONFDIR=solr.default.confdir Review Comment: After digging through the start up scripts, I learned that we don't need this variable, it's ONLY ever used internally in the start up scripts. There is a SOLR_DEFAULT_CONFDIR that is now used, which follows the pattern, which means we don't need it in this file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
