epugh commented on code in PR #3512:
URL: https://github.com/apache/solr/pull/3512#discussion_r2300839737
##########
solr/bin/solr.cmd:
##########
@@ -936,10 +936,6 @@ IF "%SOLR_MODE%"=="solrcloud" (
set "CLOUD_MODE_OPTS=!CLOUD_MODE_OPTS! -Dsolr.solrxml.required=true"
)
- IF EXIST "%SOLR_HOME%\collection1\core.properties" set
"CLOUD_MODE_OPTS=!CLOUD_MODE_OPTS! -Dbootstrap_confdir=./solr/collection1/conf
-Dcollection.configName=myconf -DnumShards=1"
Review Comment:
@malliaridis I think you made the last change in here. Can you look at
this? Basically, I believe this hardcoded "collection1" logic is no longer
needed, nor is it desirable to have a magic collection. I believe this can be
removed from both of our start scripts...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
