malliaridis commented on code in PR #3512:
URL: https://github.com/apache/solr/pull/3512#discussion_r2302076101
##########
solr/bin/solr.cmd:
##########
@@ -936,10 +936,6 @@ IF "%SOLR_MODE%"=="solrcloud" (
set "CLOUD_MODE_OPTS=!CLOUD_MODE_OPTS! -Dsolr.solrxml.required=true"
)
- IF EXIST "%SOLR_HOME%\collection1\core.properties" set
"CLOUD_MODE_OPTS=!CLOUD_MODE_OPTS! -Dbootstrap_confdir=./solr/collection1/conf
-Dcollection.configName=myconf -DnumShards=1"
Review Comment:
I tried to get some information from the git history. This addition is quite
old, and by looking up "collection1" in our project, we have a lot of tests
using this keyword / collection name. I am not sure if any of the tests may
still need it.
I am all for removing it, but we should make sure that all these references
are not making automatic use of it by having a file present in cloud mode and
by using the CLI script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
