dsmiley commented on code in PR #3512:
URL: https://github.com/apache/solr/pull/3512#discussion_r2301054829
##########
solr/packaging/test/test_start_solr.bats:
##########
@@ -93,3 +93,17 @@ teardown() {
solr start --jettyconfig "--module=server"
solr assert --started http://localhost:${SOLR_PORT} --timeout 5000
}
+
+@test "bootstrap configset using bootstrap_confdir and collection.configName" {
+ local
confdir_path="${SOLR_TIP}/server/solr/configsets/sample_techproducts_configs/conf"
+ test -d "${confdir_path}"
+
+ # This uploads the sample_techproducts_configs/conf directory as
"techproducts_bootstrapped" configset
+ solr start -Dbootstrap_confdir="${confdir_path}"
-Dcollection.configName=techproducts_bootstrapped
+ solr assert --started http://localhost:${SOLR_PORT} --timeout 5000
+
+ # Allow time for the configset upload to complete
+ sleep 1
Review Comment:
Solr does not upload these asynchronously. If Solr has started, the
configset should be there
##########
solr/bin/solr.cmd:
##########
@@ -936,10 +936,6 @@ IF "%SOLR_MODE%"=="solrcloud" (
set "CLOUD_MODE_OPTS=!CLOUD_MODE_OPTS! -Dsolr.solrxml.required=true"
)
- IF EXIST "%SOLR_HOME%\collection1\core.properties" set
"CLOUD_MODE_OPTS=!CLOUD_MODE_OPTS! -Dbootstrap_confdir=./solr/collection1/conf
-Dcollection.configName=myconf -DnumShards=1"
Review Comment:
+1 definitely don't want to see "collection1" in our startup scripts
##########
solr/packaging/test/test_start_solr.bats:
##########
@@ -93,3 +93,17 @@ teardown() {
solr start --jettyconfig "--module=server"
solr assert --started http://localhost:${SOLR_PORT} --timeout 5000
}
+
+@test "bootstrap configset using bootstrap_confdir and collection.configName" {
+ local
confdir_path="${SOLR_TIP}/server/solr/configsets/sample_techproducts_configs/conf"
+ test -d "${confdir_path}"
+
+ # This uploads the sample_techproducts_configs/conf directory as
"techproducts_bootstrapped" configset
+ solr start -Dbootstrap_confdir="${confdir_path}"
-Dcollection.configName=techproducts_bootstrapped
Review Comment:
I was hoping you would rename these given the new system property /
environment var naming scheme
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
