epugh commented on code in PR #3512:
URL: https://github.com/apache/solr/pull/3512#discussion_r2307821003
##########
solr/core/src/java/org/apache/solr/core/ConfigSetService.java:
##########
@@ -122,15 +116,19 @@ private void bootstrapDefaultConf() throws IOException {
}
private void bootstrapConfDir(String confDir) throws IOException {
- Path configPath = Path.of(confDir);
+ if (!confDir.endsWith("conf")) {
+ throw new IllegalArgumentException(
+ "solr.configset.bootstrap.confdir must point to 'conf' directory,
confDir: " + confDir);
+ }
+
+ Path configPath = resolvePathWithSolrInstallDir(confDir);
+
if (!Files.isDirectory(configPath)) {
throw new IllegalArgumentException(
- "bootstrap_confdir must be a directory of configuration files,
configPath: "
+ "solr.configset.bootstrap.confdir must be a directory of
configuration files, configPath: "
+ configPath);
}
- String confName =
- System.getProperty(
- ZkController.COLLECTION_PARAM_PREFIX +
ZkController.CONFIGNAME_PROP, "configuration1");
+ String confName = System.getProperty("solr.collection.config.name",
"configuration1");
Review Comment:
right!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
