janhoy commented on code in PR #4236: URL: https://github.com/apache/solr/pull/4236#discussion_r3089989566
########## solr/solr-ref-guide/modules/deployment-guide/pages/solrcloud-distributed-requests.adoc: ########## Review Comment: I want to keep the scope of this **bugfix** PR low and not re-architect the whole async solution. Feel free to launch a followup JIRA to either upper the default value (after careful benchmarking) or re-architect the entire async solution, perhaps with java virtual threads and no CompletableFuture at all. I suspect there is a case this semaphote as a push-back mechanism to prevent overload of the solr nodes. Say you have an insane amount of incoming distributed requests to the cluster and no circuit-breakers in place. I can imagine nodes falling over with OOM or other symptoms if the semaphore is removed or dramatically increased. Perhaps Fullstory or others who have modified this setting in their fork can provide some insights? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
