janhoy commented on code in PR #4236:
URL: https://github.com/apache/solr/pull/4236#discussion_r3085413824
##########
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java:
##########
@@ -440,5 +443,20 @@ public void initializeMetrics(SolrMetricsContext
parentContext, Attributes attri
commExecutor =
solrMetricsContext.instrumentedExecutorService(
commExecutor, "solr.core.executor", "httpShardExecutor",
SolrInfoBean.Category.QUERY);
+ if (defaultClient != null) {
+ asyncRequestsGauge =
+ solrMetricsContext.observableLongGauge(
+ "solr.http.client.async_permits",
Review Comment:
I chose `solr.client.request.async_permits` to align with the example you
found.
I also see that the conversion from underscores to dot annotation in #4223
may have missed some metric names. Will file a followup PR to catch the
remaining ones. Good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
