janhoy commented on PR #4236: URL: https://github.com/apache/solr/pull/4236#issuecomment-4251610417
Thanks for the review @dsmiley. I believe all comments are resolved. I also fixed a failure in the test that would cause leak of a "Phaser". I beasted the test with 50 iterations --> solid. I'll wait for a final round of re-review and a 👍 before I merge and backport. I'll file this as a **blocker** for 9.11 and 10.1 once JIRA is up again. ### Root cause These two bugs fixed in this PR are not new, so why did we not get leaks in 9.7? That is related to the changes in SOLR-17819 and SOLR-17792 described in PR description, i.e. commenting out of `request.abort()` which previously prevented Jetty to double-fire. I still wonder whether that change should be reverted in 10.x line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
