dsmiley commented on code in PR #4236:
URL: https://github.com/apache/solr/pull/4236#discussion_r3086594883
##########
solr/solr-ref-guide/modules/deployment-guide/pages/solrcloud-distributed-requests.adoc:
##########
Review Comment:
I appreciate you are trying to help people out with this anecdotal
configurable thing on this page, but I feel this has gone off course if we add
anything and everything in turns of random limits/toggles that exist. This
page had a purpose once... that is getting lost...
##########
solr/solrj-jetty/src/java/org/apache/solr/client/solrj/jetty/HttpJettySolrClient.java:
##########
@@ -919,7 +910,16 @@ int availablePermits() {
}
public void waitForComplete() {
- phaser.arriveAndAwaitAdvance();
Review Comment:
good catch
##########
solr/solrj-jetty/src/java/org/apache/solr/client/solrj/jetty/HttpJettySolrClient.java:
##########
@@ -454,12 +444,14 @@ public void onHeaders(Response response) {
@Override
public void onFailure(Response response, Throwable failure) {
super.onFailure(response, failure);
- // Dispatch off the IO thread so any whenComplete retry won't
block on
- // semaphore.acquire().
- failureDispatchExecutor.execute(
- () ->
- future.completeExceptionally(
- new SolrServerException(failure.getMessage(),
failure)));
+ // Dispatch off the IO thread to avoid blocking
semaphore.acquire() on retry.
+ // Fall back to IO thread if executor rejects
(shutdown/overloaded).
+ SolrServerException ex = new
SolrServerException(failure.getMessage(), failure);
+ try {
+ executor.execute(() -> future.completeExceptionally(ex));
+ } catch (RejectedExecutionException ree) {
+ future.completeExceptionally(ex);
Review Comment:
worth a warning log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
