serhiy-bzhezytskyy commented on PR #4612: URL: https://github.com/apache/solr/pull/4612#issuecomment-4900594818
Pushed a fix for the cross-dc-manager CI failure — and it's a nice illustration of why this PR runs DAGP in report-not-fail mode. DAGP flagged the `kafka-clients` **test-classifier** jar as an unused dependency (nothing *compiles* against it), so I'd removed it. But it's needed at **runtime**: `EmbeddedKafkaCluster` (from the kafka-streams test jar) loads `org.apache.kafka.test.TestCondition` from it, so the `*IntegrationTest` suites failed with `ClassNotFoundException`. Re-added as `testRuntimeOnly` (the accurate scope — runtime, not compile) with a comment. Reproduced locally and both previously-failing suites (`ZkConfigIntegrationTest`, `SolrAndKafkaIntegrationTest`) now pass. This is precisely the kind of case where the tool's advice needs human judgement rather than blanket enforcement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
