serhiy-bzhezytskyy commented on code in PR #4612:
URL: https://github.com/apache/solr/pull/4612#discussion_r3534656724
##########
solr/solrj-jetty/build.gradle:
##########
Review Comment:
Agreed — and done. I removed `testImplementation
project(':solr:solrj-jetty')` (the module test-depending on itself; the test
source set already sees its own main classes) and the duplicate
`testImplementation project(':solr:solrj')` (already `api
project(':solr:solrj')`). Kept the `configuration: 'testArtifacts'` one since
that provides solrj's test classes. Verified test compiles and all 59 tests
pass. (In fairness to the tool: it flags these via transitive-usage analysis
rather than a redundancy check, and solrj-jetty was the only
genuinely-redundant case repo-wide — but it's exactly the kind of
st-the-obvious declaration you meant, so glad to drop it.)
##########
gradle/validation/dependency-analyze.gradle:
##########
Review Comment:
Good to know, thanks. The build is currently all Groovy
(`solr/ui/build.gradle.kts` is the only Kotlin build file, and that's because
the UI is a KMP module), so I kept this consistent with the other
`gradle/validation/*.gradle` scripts for now. Happy to write it in Kotlin DSL
instead if that's the direction you'd prefer for new build files — just say the
word.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
