serhiy-bzhezytskyy commented on code in PR #4612: URL: https://github.com/apache/solr/pull/4612#discussion_r3534649251
########## changelog/unreleased/dagp-dependency-analysis-PR4612.yml: ########## @@ -0,0 +1,7 @@ +title: Add dependency-analysis (build-health) reporting to the build, and apply its uncontroversial advice (unused-dependency removals and test-scope corrections) +type: changed Review Comment: Fixed — changed to `type: other`. Thanks. ########## changelog/unreleased/dagp-dependency-analysis-PR4612.yml: ########## @@ -0,0 +1,7 @@ +title: Add dependency-analysis (build-health) reporting to the build, and apply its uncontroversial advice (unused-dependency removals and test-scope corrections) +type: changed +authors: + - name: Serhiy Bzhezytskyy +links: +- name: PR#4612 + url: https://github.com/apache/solr/pull/4612 Review Comment: Done — created SOLR-18302 for this work and switched the link to the JIRA. (The PRs were previously mis-titled with SOLR-18296, which is actually the google-java-format issue; corrected now.) ########## gradle/validation/dependencies.gradle: ########## @@ -113,7 +113,8 @@ allprojects { // This may not be the case where this task is added as a dependency, like for "dependencies" task project.configurations.findAll { // Add any custom filtering on the configurations to be resolved - it.canBeResolved + it.canBeResolved && + !it.attributes.keySet().any {attr -> attr.name.startsWith("dagp.")} Review Comment: This is a workaround for the lockfile task. The plugin adds synthetic `dagp.*` attributes to some configurations it creates; when `resolveAndLockAll` iterates every resolvable configuration, those synthetic ones fail to resolve and break `--write-locks`. The filter skips only configurations carrying a `dagp.` attribute, leaving all real ones locked as before. Happy to add a short comment there if you'd like it documented in place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
