serhiy-bzhezytskyy commented on PR #4640: URL: https://github.com/apache/solr/pull/4640#issuecomment-5599293955
Five tests were failing, and they predate the main merge: main alone is green, this branch alone fails the same five. Four came from one decision in this PR -- canonicalising in the client for every request. `JsonMapResponseParser` is public, and twenty existing call sites read the Maps and Lists it has always returned, so the conversion changed their contract silently; the four that broke were the ones that happened to have tests. The parser now keeps its old behaviour and `canonical()` offers the conversion to the ten callers that pass the response to a response object. That is the same reasoning you gave against replacing every NamedList with a SimpleOrderedMap, applied one level down. The fifth was a plain bug: `SolrParams.of` rejects a null value, so a parser asking for no `wt` threw where `ModifiableSolrParams.set` had omitted the param. `solr:core` and `solrj` are green -- 7,103 tests, 0 failures -- and `check -x test` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
