serhiy-bzhezytskyy commented on code in PR #4640: URL: https://github.com/apache/solr/pull/4640#discussion_r3966573592
########## solr/solrj/src/test/org/apache/solr/client/solrj/response/ResponseNormalizerTest.java: ########## Review Comment: Both forms are covered. Named children arrive stamped with `_nest_path_`/`_nest_parent_` and are rebuilt as child documents -- `testNamedNestedDocumentsAreReconstructed`, with paths like `/toppings#0` and a grandchild. Anonymous ones arrive as a `_childDocuments_` list -- `testChildDocumentsAreReconstructed` and `testChildDocumentsNest`. If the anonymous form is deprecated, that branch and its two tests go with it. ########## solr/solrj/src/test/org/apache/solr/client/solrj/response/TestSuggesterResponse.java: ########## Review Comment: That philosophy is worth the detour, thanks. The scale is also the reason I did not reach for it here: 592 classes extend SolrTestCaseJ4 and 264 SolrCloudTestCase, and nothing in the test framework randomizes the response parser today, so making the default a settable supplier flips ~850 classes in one step. That deserves its own change and its own failure list. Randomizing `wt` in TestSuggesterResponse is as far as I took it in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
