serhiy-bzhezytskyy commented on code in PR #4640:
URL: https://github.com/apache/solr/pull/4640#discussion_r3986397520
##########
solr/solrj/src/java/org/apache/solr/client/solrj/response/json/JsonMapResponseParser.java:
##########
@@ -78,12 +103,13 @@ public Set<String> getContentTypes() {
*/
@Override
public SolrParams getAdditionalRequestParams() {
- return REQUEST_PARAMS;
+ return canonical ? REQUEST_PARAMS : null;
Review Comment:
Renamed to `CANONICAL_PARAMS`.
##########
solr/solrj/src/java/org/apache/solr/client/solrj/response/ResponseCanonicalizer.java:
##########
Review Comment:
Renamed to `ResponseCanonicalizer`, and `normalize`/`normalizeValue` with it
-- otherwise `ResponseCanonicalizer.normalize` keeps the one mismatch the
rename removes, with `processCanonicalResponse`, `canonical()` and the
`canonical` field already next to it. The class is new in this PR, so nothing
outside it is reached.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
