serhiy-bzhezytskyy commented on PR #4640: URL: https://github.com/apache/solr/pull/4640#issuecomment-5643803855
Done: `CanonicalJsonResponseParser extends JsonMapResponseParser`, overriding `getAdditionalRequestParams` and `processCanonicalResponse`. The boolean and the `canonical()` factory are gone, and `JsonMapResponseParser` is back to what main has (0-line diff). Two tests had used `canonical()` with `processResponse`, where the flag changed nothing; they use the plain parser now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
