janhoy commented on PR #827: URL: https://github.com/apache/solr-operator/pull/827#issuecomment-6314957997
> introducing a breaking change does not feel right, i was able to get the current operator to work against solr 10 just by pointing it to a valid solr.xml I agree on this point. Solr Operator should know how to detect a cluster version based on current config. Proposal: If the `image.tag` prefix complies with normal semVer, e.g. `10.1.0`, `9.11.0`, `10.1.0-SNAPSHOT`, `10.2.0-my-company-custom-overlay-9.3`, then deduce major version from imageTag. If the tag does not comply, fall back to parsing an optional `solrMajorVersion´, if that is not set, log error and abort. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
