HoustonPutman commented on PR #827: URL: https://github.com/apache/solr-operator/pull/827#issuecomment-6323880421
> > introducing a breaking change does not feel right, i was able to get the current operator to work against solr 10 just by pointing it to a valid solr.xml > > I agree on this point. Solr Operator should know how to detect a cluster version based on current config. Proposal: > > If the `image.tag` prefix complies with normal semVer, e.g. `10.1.0`, `9.11.0`, `10.1.0-SNAPSHOT`, `10.2.0-my-company-custom-overlay-9.3`, then deduce major version from imageTag. If the tag does not comply, fall back to parsing an optional `solrMajorVersion´, if that is not set, log error and abort. Yeah, I like this. Though I would add, that maybe there are non-semver-compliant `.a.b.c.d.e` versions, that we should be ok with too. But I actually want to stay away from solrMajorVersion entirely, I really really really hate that we would need that ever. For these bad edge cases, I can accept parsing tags. But that will go away soon, and will happen very rarely hopefully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
