epugh commented on code in PR #5190: URL: https://github.com/apache/solr/pull/5190#discussion_r4343228646
########## solr/solr-ref-guide/modules/deployment-guide/pages/cli/index.adoc: ########## @@ -1,4 +1,4 @@ -= Experimental picocli Command Line Interface += Picocli Command Line Interface Review Comment: I don't think our end users care that we use Picocli under the covers ;-). I think just drop that part. ########## solr/solr-ref-guide/modules/deployment-guide/pages/cli/index.adoc: ########## @@ -17,42 +17,31 @@ // specific language governing permissions and limitations // under the License. -Solr is migrating the `bin/solr` command line tool from Apache Commons CLI to https://picocli.info/[picocli]. -While that work is in progress, both implementations ship together and the picocli one can be enabled on request. +Solr has migrated the `bin/solr` command line tool from Apache Commons CLI to https://picocli.info/[picocli]. Review Comment: This should be removed on Solr 11 Ref Guide, of course, we need it on solr 10. I hope we see commons-cli removed from Solr 11 very soon! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
