jaykay12 commented on code in PR #5190:
URL: https://github.com/apache/solr/pull/5190#discussion_r4347513260
##########
solr/packaging/build.gradle:
##########
@@ -338,26 +338,38 @@ def configureBatsTask(BatsTask task, String outputName,
boolean usePicocli) {
task.environment TEST_OUTPUT_DIR: integrationTestOutput
task.environment TEST_FAILURE_DIR: solrTestFailuresDir
task.environment BATS_LIB_PREFIX: batsLibsDir
- if (usePicocli) {
- task.environment SOLR_PICOCLI: 'true'
+ if (!usePicocli) {
+ task.environment SOLR_PICOCLI: 'false'
}
}
+// TODO: Remove this when cleaning up commons-cli
task integrationTests(type: BatsTask) {
+ description = 'Runs the BATS suites for the CLI powered by commons-cli.'
configureBatsTask(it, 'test-output', false)
}
-// The same suites run against the experimental picocli CLI. Deliberately a
curated list rather
-// than the whole suite, so the run stays short. A change that ports another
tool to picocli
-// should add that tool's .bats file here.
+// The same suites run against the picocli CLI.
task integrationTestsPicocli(type: BatsTask) {
- description = 'Runs the BATS suites for the migrated commands against the
experimental picocli CLI.'
+ description = 'Runs the BATS suites for the CLI powered by PicoCLI.'
configureBatsTask(it, 'test-output-picocli', true)
- // A suite belongs here only when every command it invokes has been
migrated, not merely the
- // command under test. test_auth.bats, for example, uses `solr assert` to
wait for startup, so
- // it cannot join until the assert command is migrated. test_help.bats
asserts the exact wording
- // of the commons-cli help output, which the picocli implementation words
differently.
+ // TODO: Remove these explicit files entry from here after fixing 4
remaining bats file
testFiles = [
+ 'test/test_adminconsole_urls.bats',
+ 'test/test_assert.bats',
+ 'test/test_bats.bats',
+ 'test/test_compression.bats',
+ 'test/test_config.bats',
+ 'test/test_create_collection.bats',
+ 'test/test_example.bats',
+ 'test/test_export.bats',
+ 'test/test_opennlp.bats',
+ 'test/test_placement_plugin.bats',
+ 'test/test_rolling_upgrade.bats',
+ 'test/test_snapshots.bats',
+ 'test/test_ssl.bats',
+ 'test/test_start_solr.bats',
+ 'test/test_zz_cleanup.bats',
Review Comment:
there are 4 bats that requires fix, I will be raising a follow-up PR for the
same, for now added a Todo here & adding the remaining bats.
this takes us from 41 -> 92 assertions now.
<img width="595" height="297" alt="Image"
src="https://github.com/user-attachments/assets/4593ec71-4f14-45f9-9e98-6fa906d24b60";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
