jaykay12 commented on code in PR #5190:
URL: https://github.com/apache/solr/pull/5190#discussion_r4346069097
##########
solr/packaging/build.gradle:
##########
@@ -338,20 +338,20 @@ def configureBatsTask(BatsTask task, String outputName,
boolean usePicocli) {
task.environment TEST_OUTPUT_DIR: integrationTestOutput
task.environment TEST_FAILURE_DIR: solrTestFailuresDir
task.environment BATS_LIB_PREFIX: batsLibsDir
- if (usePicocli) {
- task.environment SOLR_PICOCLI: 'true'
+ if (!usePicocli) {
+ task.environment SOLR_PICOCLI: 'false'
}
}
+// TODO: Remove this when cleaning up commons-cli
task integrationTests(type: BatsTask) {
+ description = 'Runs the BATS suites for the CLI powered by commons-cli.'
configureBatsTask(it, 'test-output', false)
}
-// The same suites run against the experimental picocli CLI. Deliberately a
curated list rather
-// than the whole suite, so the run stays short. A change that ports another
tool to picocli
-// should add that tool's .bats file here.
+// The same suites run against the picocli CLI.
task integrationTestsPicocli(type: BatsTask) {
- description = 'Runs the BATS suites for the migrated commands against the
experimental picocli CLI.'
+ description = 'Runs the BATS suites for the CLI powered by PicoCLI.'
configureBatsTask(it, 'test-output-picocli', true)
Review Comment:
Right now PicoCLI bats runs on 41 assertions, moving all 127 bats
(commons-cli) to picoCLI will be a follow-up PR.
for the 41 current, bats pass locally, verified. ✅
<img width="601" height="341" alt="Image"
src="https://github.com/user-attachments/assets/da6b6205-7c5f-4b69-9e9a-9bc178d8ae46";
/>
##########
solr/packaging/build.gradle:
##########
@@ -338,20 +338,20 @@ def configureBatsTask(BatsTask task, String outputName,
boolean usePicocli) {
task.environment TEST_OUTPUT_DIR: integrationTestOutput
task.environment TEST_FAILURE_DIR: solrTestFailuresDir
task.environment BATS_LIB_PREFIX: batsLibsDir
- if (usePicocli) {
- task.environment SOLR_PICOCLI: 'true'
+ if (!usePicocli) {
+ task.environment SOLR_PICOCLI: 'false'
}
}
+// TODO: Remove this when cleaning up commons-cli
task integrationTests(type: BatsTask) {
+ description = 'Runs the BATS suites for the CLI powered by commons-cli.'
configureBatsTask(it, 'test-output', false)
}
-// The same suites run against the experimental picocli CLI. Deliberately a
curated list rather
-// than the whole suite, so the run stays short. A change that ports another
tool to picocli
-// should add that tool's .bats file here.
+// The same suites run against the picocli CLI.
task integrationTestsPicocli(type: BatsTask) {
- description = 'Runs the BATS suites for the migrated commands against the
experimental picocli CLI.'
+ description = 'Runs the BATS suites for the CLI powered by PicoCLI.'
configureBatsTask(it, 'test-output-picocli', true)
Review Comment:
if reviewers, want that PR to land first, before this PR, I will prioritise
that. but it will be a separate PR for sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
