nick-boss-tech commented on PR #5190:
URL: https://github.com/apache/solr/pull/5190#issuecomment-6335031669
Thanks for this. SOLR_PICOCLI=false is the escape hatch as described. Two
things to tidy before merge:
The changelog file is still named
changelog/unreleased/SOLR-17697-migrate-cli-to-picocli.yml. This PR is
SOLR-18561, so the file name should match.
The PR body has "I have run ./gradlew check" and "I have added tests"
unchecked. Because the default flips for every tool, a bats case for the
fallback would make it explicit. For example, in
solr/packaging/test/test_help.bats:
@test "create help with SOLR_PICOCLI=false uses the commons-cli fallback" {
SOLR_PICOCLI=false run solr create --help
assert_success
assert_output --partial 'bin/solr create'
refute_output --partial 'Usage: solr create'
}
The expected strings are not yet confirmed by a run. Check them on the bats
host before relying on them.
The "Run Solr Script Tests" job fails on one assertion in test_ssl.bats
(test 88, line 103). On the ubuntu-26.04 runner, curl says "target hostname"
where the test expects "target host name". The PR can't merge while that job
fails. The fix is [PR #5193](https://github.com/apache/solr/pull/5193) for
[SOLR-18565](https://issues.apache.org/jira/browse/SOLR-18565), a one-line
change. Once that is on main, rebasing this PR should clear the check.
_AI-generated comment._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
