[
https://issues.apache.org/jira/browse/TAJO-1114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183993#comment-14183993
]
ASF GitHub Bot commented on TAJO-1114:
--------------------------------------
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/206#discussion_r19374125
--- Diff: tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java ---
@@ -143,54 +156,61 @@ public static int setDateOrder(int dateOrder) {
///////////////////////////////////////////////////////////////////////////////////////
// a username for a running Tajo cluster
- ROOT_DIR("tajo.rootdir", "file:///tmp/tajo-${user.name}/"),
- USERNAME("tajo.username", "${user.name}"),
+ ROOT_DIR("tajo.rootdir", "file:///tmp/tajo-${user.name}/",
+ Validators.groups(Validators.notNull(), Validators.pathUrl())),
+ USERNAME("tajo.username", "${user.name}",
+ Validators.groups(Validators.notNull(), Validators.shellVar())),
--- End diff --
Shell variable (i.e., ```${user.name}) is translated in Hadoop's
Configuration. Actually, this config is just a string.
> Improve ConfVars (SessionVar) to take a validator interface to check its
> input.
> -------------------------------------------------------------------------------
>
> Key: TAJO-1114
> URL: https://issues.apache.org/jira/browse/TAJO-1114
> Project: Tajo
> Issue Type: Task
> Reporter: Hyunsik Choi
> Assignee: Jihun Kang
> Fix For: 0.9.1
>
>
> Each task uses session variables from client or configs from tajo-site.xml.
> The session variables and configs are used in task during query processing.
> If invalid configs or invalid session variables are used for a query, the
> error will be caused in a runtime instead of query init phase. It's bad
> situation. Invalid values must be detected at the initialization phase.
> Because each session variable or config varies in its value type and value
> range, It would be great if each ConfigKey takes a validator for its value
> and Tajo uses validators for it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
