[
https://issues.apache.org/jira/browse/TAJO-1114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184002#comment-14184002
]
ASF GitHub Bot commented on TAJO-1114:
--------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/206#issuecomment-60473494
I greatly appreciate your contribution. The patch looks really great. I
love your design.
Actually, I didn't mention how we validate each config key. Of course, it
is out of scope of this issue. Now, I just share it with you.
In my plan, Tajo will validate configs in two ways.
The first way is that TajoMaster validates each config when it starts up.
If TajoMaster finds invalid config which probably will cause query runtime
errors, TajoMaster will shutdown immediately and prints out detailed error
messages. If so, we can earlier prohibit some kind of query runtime errors.
The second one is that TajoMaster checks each session setting action by
client. If a client sets an invalid session variable, it will show some errors
and prohibit putting the invalid variable into session variables.
If you fix the validator for ```tajo.username``` and rebase it, I'll finish
the review.
Best regards,
Hyunsik
> Improve ConfVars (SessionVar) to take a validator interface to check its
> input.
> -------------------------------------------------------------------------------
>
> Key: TAJO-1114
> URL: https://issues.apache.org/jira/browse/TAJO-1114
> Project: Tajo
> Issue Type: Task
> Reporter: Hyunsik Choi
> Assignee: Jihun Kang
> Fix For: 0.9.1
>
>
> Each task uses session variables from client or configs from tajo-site.xml.
> The session variables and configs are used in task during query processing.
> If invalid configs or invalid session variables are used for a query, the
> error will be caused in a runtime instead of query init phase. It's bad
> situation. Invalid values must be detected at the initialization phase.
> Because each session variable or config varies in its value type and value
> range, It would be great if each ConfigKey takes a validator for its value
> and Tajo uses validators for it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
