[ 
https://issues.apache.org/jira/browse/TAJO-1114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184982#comment-14184982
 ] 

ASF GitHub Bot commented on TAJO-1114:
--------------------------------------

GitHub user ykrips opened a pull request:

    https://github.com/apache/tajo/pull/214

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

    This pull request continues the previous pull request. 
    Previous pull request can be found in this link.
    https://github.com/apache/tajo/pull/206

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ykrips/tajo TAJO-1114

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/214.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #214
    
----
commit 412e2e6b8fcd208ded929df100d2ee80ee7a0281
Author: Jihun Kang <[email protected]>
Date:   2014-10-17T09:53:13Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit 44b991b43318da6d91758c3ef43232bd71414352
Author: Jihun Kang <[email protected]>
Date:   2014-10-20T06:47:34Z

    Merge remote-tracking branch 'upstream/master' into TAJO-1114

commit 76720f853dd22b245207d2de8e49fcc9554562f5
Author: Jihun Kang <[email protected]>
Date:   2014-10-20T07:13:01Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit f99e7edcfa51c2955da7a54af4a2edf7b11c6068
Author: Jihun Kang <[email protected]>
Date:   2014-10-20T07:13:53Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit 0ad448d1e51a35778b527a952dbd2c36345579e5
Author: Jihun Kang <[email protected]>
Date:   2014-10-20T07:15:00Z

    Merge remote-tracking branch 'upstream/master' into TAJO-1114

commit ce0fb6d44e5782c28618b735d95b10c57d3f4692
Author: Jihun Kang <[email protected]>
Date:   2014-10-20T12:47:27Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit 3f3a23a138cc523316cd2b28f1251921a55d404e
Author: Jihun Kang <[email protected]>
Date:   2014-10-20T13:02:30Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit b953102a48bb75136172a584d95191273a386903
Author: Jihun Kang <[email protected]>
Date:   2014-10-17T09:53:13Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit c510067ce5665a431230e5e56efa574f014bb85d
Author: Jihun Kang <[email protected]>
Date:   2014-10-20T07:13:01Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit 9d666ef75662c36e825b6bcdc1cd22e30d6c59af
Author: Jihun Kang <[email protected]>
Date:   2014-10-20T07:13:53Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit 1b5088bcf515f2e6706be1d1dbec515a9885b8e4
Author: Jihun Kang <[email protected]>
Date:   2014-10-20T12:47:27Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit 7c92470a100732434e3aa453978c5b498eecca6e
Author: Jihun Kang <[email protected]>
Date:   2014-10-20T13:02:30Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit b49df082a32d2bb5a987c7444b0b4b0e94fa8836
Author: Jihun Kang <[email protected]>
Date:   2014-10-27T08:52:58Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit cc5d128a3a5c2701ed119b7d6de9b8aa81799c08
Author: Jihun Kang <[email protected]>
Date:   2014-10-27T09:00:32Z

    TAJO-1114: Improve ConfVars (SessionVar) to take a validator interface to 
check its input.

commit 5b5fc3995cba4fced25563b35e1966db5a8812d9
Author: Jihun Kang <[email protected]>
Date:   2014-10-27T09:10:41Z

    Removed validate functions from OverridableConf

commit d0ee8cd3c52cec0588af53ad8554e40ba437f711
Author: Jihun Kang <[email protected]>
Date:   2014-10-27T09:14:09Z

    Removed unused conf

----


> Improve ConfVars (SessionVar) to take a validator interface to check its 
> input.
> -------------------------------------------------------------------------------
>
>                 Key: TAJO-1114
>                 URL: https://issues.apache.org/jira/browse/TAJO-1114
>             Project: Tajo
>          Issue Type: Task
>            Reporter: Hyunsik Choi
>            Assignee: Jihun Kang
>             Fix For: 0.9.1
>
>
> Each task uses session variables from client or configs from tajo-site.xml. 
> The session variables and configs are used in task during query processing.
> If invalid configs or invalid session variables are used for a query, the 
> error will be caused in a runtime instead of query init phase. It's bad 
> situation. Invalid values must be detected at the initialization phase.
>  Because each session variable or config varies in its value type and value 
> range, It would be great if each ConfigKey takes a validator for its value 
> and Tajo uses validators for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to