> > > Great too ! How is it accessed ? Serial ? i2c ? chip-specific protocol ?
>
> > The ds1302 is, as you can see in the schematic, serial, but whit a
> > chip-specific protocol, connected to the pic.
>
> OK, so it must use serial_hardware.jal lib from jallib.
No serial_hardware.jal is not used just a simple routine
> OK, but you used the original jallist file (or whatever the source), as a
> start, you ***MUST*** keep the original author's name, and mention you
> *adapted* it. This is very, very important. Same for lcd.
All three are not adapted but completely written new the only
similarity in both LCD libs are the constant definition,
Witch I saw in Berts lcd lib and in Wouters lcd lib and thought it’s a
nice way to make your lib more readable.
If there would be any other similarity to an other LCD library than it
would be probably with Berts because I checked his library before
making mine.
To be on the safe side I will ask Bert opinion because I don’t want to
make the impression that I steel somebody’s idea or libs.
> Following this, we would have to add datasheets for each PIC, jallib' SVN is
> not the place for this. Just a link in header could be enough. I can add a
> "Links:" field in it, so a script can check if links are still active.
>
> For now, if you all agree can you remove them ?
i already removed them.
>
> > In the map "Sample" you can find "test display hd44780 4 line" and
> > "test display hd44780 8 line" the only difference between those 2 file
> > is the initialisation section of the display so you can see how the to
> > set to nibble or 8 line (both are tested by me).
>
> Great. Few comments though...:
>
> * I can't compile your samples. It includes "16f877_ok.jal" which obviously
> doesn't exist in jallib. Each sample must be written against jallib repos:
> using device file and libraries. Before committing, a good practice is to
> check it compiles ok against jallib.
I understand but I can’t find any validated 16f877 include files yet
and I hoped you all can say if you want to use the lib.
If not, because you already have a good one, no problem but then it is
not necessary to change it all to repository.
Then maybe its better to change the st7036 functionality to your lcd
lib to keep a standard.
If you want to test it you can change the 16f887?ok.jal to your own
16f887 include file should be no problem except you have to remove
some parameters in the main file because they are probably already
assigned in the common include files
>
> * avoid spaces in filenames, this can sometimes be a nightmare. Use
> underscore ("_"). Also note all files must be lowercased (not capitals).
done
>
> * be careful with indentation
to mutch ore to big?
>
> * there's no "include lcd" statement in your sample, probably because it's
> done in 16f877_ok.jal. Keep in mind that samples must show how to use the
> lib, from scratch, with the needed details. The minimal use.
sorry wrong include name, is now changed
>
> > In the map "RTC" I have add the lib "rtc_ds1302 and in the map "lcd"
> > you can find the lib "lcd_hd44780_tmp"
>
> > St7036 I will add later if you are satisfied with the hd44780
> > procedures because I think the st7036 should have the same options as
> > the hd44780.
>
> what options are you talking about ?
> I think st7036 is more important, since we already have a hd44780 lib.
As a mentioned above maybe its better to change the st7036 to the
functionality of your hd44780 to keep a standard and to remove mine
hd44780.
> You could add 2 issues, something like: "Integrate ST7036 lcd lib" and
> "Integrate DS1302 RTC lib", where you'll describe what's to be done. It's
> also a nice place to put problems encountered during development, it can
> help for other issues. Have a look at existing ones to have an idea !
I did, I understand now what you mean.
Greetz
Richard
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"jallib" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/jallib?hl=en
-~----------~----~----~----~------~----~------~--~---
