> No serial_hardware.jal is not used just a simple routine OK, I've no time right now to have a look, but maybe it's better to use existing serial_hardware.jal. See sample to understand how to use it.
> To be on the safe side I will ask Bert opinion because I don’t want to > make the impression that I steel somebody’s idea or libs. OK. I've seen your jallist post. > I understand but I can’t find any validated 16f877 include files yet > and I hoped you all can say if you want to use the lib If you mean in "/validated" dir, it's normal, since there's no release yet. You have to deal with "/unvalidated", where you'll find a 16f877.jal file. > If not, because you already have a good one, no problem but then it is > not necessary to change it all to repository. We won't add any device files except those generated by Rob's dev2jal script. See /unvalidated/include/device to see them all. > Then maybe its better to change the st7036 functionality to your lcd > lib to keep a standard. > If you want to test it you can change the 16f887?ok.jal to your own > 16f887 include file should be no problem except you have to remove > some parameters in the main file because they are probably already > assigned in the common include files Is it ok for *you* to re-write the sample using our device file ? There's probably more than just an include to change. > > * be careful with indentation > > to mutch ore to big? No, not consistent. Sometime it's indented with 2 spaces, sometimes more. Sometimes it doesn't need to be indented, but suddenly becomes to be indented. This actually quite confusing when reading the code, you sometime don't know if you're in a procedure or not, if you're on the main, etc... When entering a block (procedure/function/if/for, ...) you need to indent one level more, etc... See existing lib as examples. > As a mentioned above maybe its better to change the st7036 to the > functionality of your hd44780 to keep a standard and to remove mine > hd44780. OK, I'm not sure to understand the whole thing, but I suggest the following: * since we already have a hd44780 lib, your lib *might* not be useful. Maybe you could test the existing ones, with the provided samples (sample/external/lcd) (Note these samples need more work, since not JSG compliant. Eur ?). If you think it must be improved, we'll include some of your lib, as a external lib (another extra lib), or within the existing lib file, we'll see. * put your st7036 lib to the repos, we'll have a look, change include statements as needed, then we'll create samples. What do you think about this ? Is it ok for you ? Cheers, Seb -- Sébastien LELONG http://www.sirloon.net http://sirbot.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/jallib?hl=en -~----------~----~----~----~------~----~------~--~---
