Hi Seb
apart from the 3 procedures:
_lcd_send
_lcd_send_command
_lcd_send_data
which I copied ( is very common code and found on the internet )
so it is not based on the original one.
The file will not be appended to jallib as it is and will not be
updated( the copyright line is removed ) any more.
I have left the file for the sake of discussion only
Paul
It is not based on the original one
On 16 Dec., 11:19, Sebastien Lelong <[email protected]>
wrote:
> Hi Paul,
>
> I understand glcd_graphics.jal is for 3310 display. Doesn't it conflict with
> existing one
> ?http://code.google.com/p/jallib/source/browse/trunk/include/external/...
>
> Or, is your based on it ? If so, original author should be kept in header...
>
> Cheers,
> Seb
>
> 2010/12/16 pdhaene <[email protected]>
>
>
>
>
>
>
>
>
>
> > Sebastian try:
> >http://www.copada.dk/jal/glcd_graphics.jal
> >http://www.copada.dk/jal/glcd_graphics_test.jal
>
> > Paul
>
> > On 16 Dec., 08:01, Sebastien Lelong <[email protected]>
> > wrote:
> > > Hi guys,
>
> > > I'm trying to follow the discussion. I have a 3310 GLCD around, I'll try
> > to
> > > setup something so I can test some of your code. I don't know yet if I'll
> > > have time to help, but at least I should be able to be naive yet picky
> > user
> > > :)
>
> > > 2010/12/16 mattschinkel <[email protected]>
>
> > > > Just some notes after looking at your new code. again, only
> > > > suggestions.
>
> > > > 1. print_char & print_char_i could become one procedure. A constant or
> > > > variable (the user can decide in his sample) could set what direction
> > > > a character is printed. A constant can tell the library how the font
> > > > array is set-up (see my notes above).
>
> > > By looking at the name and comments, I thought print_char_i printed a
> > > inverted char, ie. white over black...
>
> > > > 2. my glcd is > 256 pixels (240x320), therefore I can't draw anything
> > > > in the rest of my screen with your procedures. I had put a fix into
> > > > glcd_common (byte*x in var)
> > > > 3. Maybe glcd_common_graphics_X01.jal could be renamed and made into
> > > > glcd_cache? the current name suggests that it draws graphics (like
> > > > line, circle, etc).
>
> > > I agree !
>
> > > > 4. glcd_Nokia_3310_X01.jal, glcd_Samsung_KS0108_X01.jal should have a
> > > > procedure like lcd_write_pixel(byte in x,byte in y,byte in color). All
> > > > other libraries have this. If all libraries are the same, they can all
> > > > use the same procedure to draw things.
>
> > > I agree again, you'll need to identify primitives and implement them for
> > > each GLCD.
>
> > > Can KS0108 be found in some mobile phone too ?
>
> > > Cheers,
> > > Seb
>
> > --
> > You received this message because you are subscribed to the Google Groups
> > "jallib" group.
> > To post to this group, send email to [email protected].
> > To unsubscribe from this group, send email to
> > [email protected]<jallib%[email protected]>
> > .
> > For more options, visit this group at
> >http://groups.google.com/group/jallib?hl=en.
>
> --
> Sébastien Lelonghttp://www.sirloon.nethttp://sirbot.org
--
You received this message because you are subscribed to the Google Groups
"jallib" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/jallib?hl=en.
