Seb, thanks for joining in! We definitely need more opinions. One problem I have had, or have been working around is to keep current ks0108 and nokia3310 working. I have done so with "if !defined". It would clean up code if these old libraries could be updated to whatever it is we are going to agree on in glcd_constants. These additional statements would no longer be needed. While it is good to keep old libraries working, it also keeps new libraries from improvements and creates messy, harder to read code.
Paul, for rotated fonts, I was actually thinking that it would be better to just make a new font for them. for example, instead of a 5x8 font, you would have a 8x5 (90 degree) font & font array. These fonts should be named accordingly. I think this would save memory for those who only wish to use fonts in one direction only, which is usually the case. It also allows someone to rotate their glcd in their project if they want to look at it as tall instead of wide. What I ment by byte*x is this: const byte GLCD_X_PIXELS = 320 if GLCD_X_PIXELS < 256 then const GLCD_X_SIZE = 1 else const GLCD_X_SIZE = 2 end if var byte*GLCD_X_SIZE my_var The above example makes my_var byte*2, known as "word". Matt On Dec 16, 2:01 am, Sebastien Lelong <[email protected]> wrote: > Hi guys, > > I'm trying to follow the discussion. I have a 3310 GLCD around, I'll try to > setup something so I can test some of your code. I don't know yet if I'll > have time to help, but at least I should be able to be naive yet picky user > :) > > 2010/12/16 mattschinkel <[email protected]> > > > Just some notes after looking at your new code. again, only > > suggestions. > > > 1. print_char & print_char_i could become one procedure. A constant or > > variable (the user can decide in his sample) could set what direction > > a character is printed. A constant can tell the library how the font > > array is set-up (see my notes above). > > By looking at the name and comments, I thought print_char_i printed a > inverted char, ie. white over black... > > > 2. my glcd is > 256 pixels (240x320), therefore I can't draw anything > > in the rest of my screen with your procedures. I had put a fix into > > glcd_common (byte*x in var) > > 3. Maybe glcd_common_graphics_X01.jal could be renamed and made into > > glcd_cache? the current name suggests that it draws graphics (like > > line, circle, etc). > > I agree ! > > > 4. glcd_Nokia_3310_X01.jal, glcd_Samsung_KS0108_X01.jal should have a > > procedure like lcd_write_pixel(byte in x,byte in y,byte in color). All > > other libraries have this. If all libraries are the same, they can all > > use the same procedure to draw things. > > I agree again, you'll need to identify primitives and implement them for > each GLCD. > > Can KS0108 be found in some mobile phone too ? > > Cheers, > Seb -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
