Niall,

Please see comments in-lines.

> Name:                    SUNWzfs-auto-snapshot
> Summary:                 ZFS automatic snapshot service
> Version:                 0.11.0
> Source:                  zfs-snapshot.tar.bz2
Is there any world wide link which is available for external users?

> SUNW_BaseDir:            /
Suggest use macros in Solaris.inc, here is
SUNW_BaseDir:       %{_basedir}

> %include default-depend.inc
No other dependencies? I guess SUNWzfsu should be in.

> mkdir -p $RPM_BUILD_ROOT/etc/security
> echo 'solaris.smf.manage.zfs-auto-snapshot:::Manage the ZFS Automatic 
> Snapshot Service::' > $RPM_BUILD_ROOT/etc/security/auth_attr
Same as #1 comment, use {_sysconfdir} for /etc

> %files
> %defattr (-, root, bin)
> %dir %attr (0755, root, sys) /var
> %dir %attr (0755, root, sys) /var/svc
> %dir %attr (0755, root, sys) /var/svc/manifest
> %dir %attr (0755, root, sys) /var/svc/manifest/system
> %dir %attr (0755, root, sys) /var/svc/manifest/system/filesystem
> %class(manifest) %attr (0444, root, sys) 
> /var/svc/manifest/system/filesystem/*.xml
> %dir %attr (0755, root, bin) /lib/svc/method
> %attr (0555, root, bin) /lib/svc/method/zfs-auto-snapshot
> %dir %attr (0755, root, sys) /etc
> %dir %attr (0755, root, sys) /etc/security
> %config %class (rbac) %attr (0644, root, sys) /etc/security/auth_attr
Same as #1 comment, use {_sysconfdir} for /etc

Like SUNWtime-slider.spec, shall files under /etc
and /var/svc/manifest/system/filesystem/*.xml be separated into -root
package? 
Laca, any comment?

> Name:                    SUNWgnome-time-slider
> Summary:                 Time Slider ZFS snapshot management for GNOME
> Version:                 0.1.0
> Source:                  time-slider.tar.bz2
Same as above

> %files
> %defattr (-, root, bin)
> %{_bindir}/*
> %dir %attr (0755, root, bin) %{_libdir}
> %{_libdir}/time-slider-*
> %dir %attr (0755, root, sys) %{_datadir}
> %dir %attr (0755, root, other) %{_datadir}/applications
> %{_datadir}/applications/time-slider-*.desktop
> %{_datadir}/icons/hicolor/*/apps/time-slider-setup.png
You may meet attr conflict when install this package.
should be root:other for /usr/share/icons/hicolor/*
and /usr/share/icons/hicolor/*/apps.

You can refer SUNWgnome-session.spec


-Halton.


Reply via email to