Hi Laca, Laszlo (Laca) Peter wrote: > Niall, > > >> I've made the necessary corrections to the spec files (attached). >> The proposed source URLs are: >> >> http://dlc.sun.com/osol/jds/downloads/extras/time-slider/time-slider-%{time_slider_version}.tar.bz2 >> http://dlc.sun.com/osol/jds/downloads/extras/time-slider/zfs-snapshot-%{zfs_snapshot_version}.tar.bz2 >> > > That looks good, but it made me look at %version: > > >> # Sun Download Center. Contact GNOME RE for assistance. >> %define time_slider_version 0.1.0 >> >> Name: SUNWgnome-time-slider >> Summary: Time Slider ZFS snapshot management for GNOME >> Version: %{default_pkg_version} >> Source: >> http://dlc.sun.com/osol/jds/downloads/extras/time-slider/time-slider-%{time_slider_version}.tar.bz2 >> > > I don't think using default_pkg_version makes sense here, since it's > the GNOME version (e.g. 2.24.1). You can just use 0.1.0 for Version > and use %{version} in the Source line. > > Same for zfs snapshot. >
Ok. That makes sense. So apart from the change to version, are you otherwise happy with these 2 spec files? I plan to commit them to spec-files-other and will submit the tarballs onto blader.ireland and ask you or Damien to upload onto dlc.sun.com to the above URLs. Regarding the tarball upload, the sumbit_src_tarball script requests a project name. Is gnome-2.24 the correct project name to use for these tarballs? Thanks, Niall. > Laca > > >
