[jds-review] Spec files for SUNWzfs-auto-snapshot and SUNWgnome-time-slider

[Laszlo (Laca) Peter]

Niall,

> I've made the necessary corrections to the spec files (attached).
> The proposed source URLs are:
> 
> http://dlc.sun.com/osol/jds/downloads/extras/time-slider/time-slider-%{time_slider_version}.tar.bz2
> http://dlc.sun.com/osol/jds/downloads/extras/time-slider/zfs-snapshot-%{zfs_snapshot_version}.tar.bz2

That looks good, but it made me look at %version:

> #       Sun Download Center. Contact GNOME RE for assistance.
> %define time_slider_version 0.1.0
> 
> Name:                    SUNWgnome-time-slider
> Summary:                 Time Slider ZFS snapshot management for GNOME
> Version:                 %{default_pkg_version}
> Source:                          
> http://dlc.sun.com/osol/jds/downloads/extras/time-slider/time-slider-%{time_slider_version}.tar.bz2

I don't think using default_pkg_version makes sense here, since it's
the GNOME version (e.g. 2.24.1).  You can just use 0.1.0 for Version
and use %{version} in the Source line.

Same for zfs snapshot.

Laca