Hello, Finally took some time to review the JEP 305, thanks a lot again Jesse for that big step forward, here's some feedback:
* About using Maven CI Friendly Versions <https://maven.apache.org/maven-ci-friendly.html>: I guess we should then add also *RequireMavenVersion* 3.5+ shouldn't we? * I love the part https://github.com/jenkinsci/jep/blob/master/jep/305/RE ADME.adoc#usage-from-the-update-center and the idea that we do GitOps and get better traceability/revertability ("Emergency rollbacks are as simple as git revert." indeed). This is easily controllable manually, and can be automated/supported via additional tooling progressively. * About https://github.com/jenkinsci/jep/blob/master/jep/ 305/README.adoc#other-version-schemes I agree with the global reasoning, small concern about "borked releases". When one is using MRP, a burned release is /just/ running MRP again. If a given commit does map to a given release naming with JEP-305, then if something goes wrong during "mvn deploy", like say a failure in the middle of the physical upload, then I cannot (rightly) retry to override that borked binary. In that case, do I have to create some kind of fake commit to retry, or even *git commit -m "fake commit to retry release deploy" --allow-empty* ? 2018-04-14 13:50 GMT+02:00 Jesse Glick <jgl...@cloudbees.com>: > On Fri, Apr 13, 2018 at 8:21 PM, R. Tyler Croy <ty...@monkeypox.org> > wrote: > > [Do] you think it's important to verify that > > core and modules function with this model before rolling out this type > of a > > design? > > Yes I would consider that a prerequisite for this JEP to be Accepted > and the system to be rolled out for general use: > > https://issues.jenkins-ci.org/browse/JENKINS-50692 > > I am not sure if there is some convention for indicating in the JEP > itself, or in JIRA, which stories in an Epic like JENKINS-50686 should > be considered “mandatory” vs. “optional” for various stages (Draft, > Accepted, Final). > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to jenkinsci-dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/ms > gid/jenkinsci-dev/CANfRfr3r7VDqUYBQ1PKf4jdiSmGmOYneaqi%3Dy3S > -zm3T6%3D9wXA%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS6_3jup2kX6BpKv6znSY_%3DLyjBLBBg6PWJ8-KiM5EzJog%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
