[GitHub] [kafka] C0urante commented on a diff in pull request #12309: KAFKA-14007: Invoking connect headers.close method on shutdown

[GitBox]

C0urante commented on code in PR #12309:
URL: https://github.com/apache/kafka/pull/12309#discussion_r902098848


##########
connect/api/src/main/java/org/apache/kafka/connect/storage/StringConverter.java:
##########
@@ -104,6 +104,7 @@ public SchemaAndValue toConnectHeader(String topic, String 
headerKey, byte[] val
 
     @Override
     public void close() {
-        // do nothing
+        this.serializer.close();
+        this.deserializer.close();

Review Comment:
   Good catch here. Should we do the same in the 
[NumberConverter](https://github.com/apache/kafka/blob/30216ea1c58761e62f51af40033f24e3ae1c5c2a/connect/runtime/src/main/java/org/apache/kafka/connect/converters/NumberConverter.java#L123-L125)
 class?



##########
connect/api/src/main/java/org/apache/kafka/connect/storage/StringConverter.java:
##########
@@ -104,6 +104,7 @@ public SchemaAndValue toConnectHeader(String topic, String 
headerKey, byte[] val
 
     @Override
     public void close() {
-        // do nothing
+        this.serializer.close();
+        this.deserializer.close();

Review Comment:
   Also, even though these are no-ops right now, if we want to be meticulous 
about the cleanup logic here, should we wrap both of these in 
`Utils::closeQuietly`, so that if one fails, we still get a chance to close the 
other?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org