vamossagar12 commented on code in PR #12309: URL: https://github.com/apache/kafka/pull/12309#discussion_r902548373
########## connect/runtime/src/main/java/org/apache/kafka/connect/converters/NumberConverter.java: ########## @@ -122,5 +123,7 @@ public SchemaAndValue toConnectHeader(String topic, String headerKey, byte[] val @Override public void close() { + Utils.closeQuietly(this.serializer, "number format serializer"); Review Comment: I changed it to `number converter serializer`. Somehow had NumberFormatException in my mind when I was making this change and ended up writing `number format serializer` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org