[GitHub] [kafka] C0urante commented on a diff in pull request #12309: KAFKA-14007: Invoking connect headers.close method on shutdown

[GitBox]

C0urante commented on code in PR #12309:
URL: https://github.com/apache/kafka/pull/12309#discussion_r902543197


##########
connect/json/src/main/java/org/apache/kafka/connect/json/JsonConverter.java:
##########
@@ -282,7 +282,8 @@ public void configure(Map<String, ?> configs, boolean 
isKey) {
 
     @Override
     public void close() {
-        // do nothing
+        this.serializer.close();
+        this.deserializer.close();

Review Comment:
   ```suggestion
           Utils.closeQuietly(this.serializer, "JSON converter serializer");
           Utils.closeQuietly(this.deserializer, "JSON converter deserializer");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org