[GitHub] [kafka] C0urante commented on a diff in pull request #12309: KAFKA-14007: Invoking connect headers.close method on shutdown

[GitBox]

C0urante commented on code in PR #12309:
URL: https://github.com/apache/kafka/pull/12309#discussion_r902544147


##########
connect/runtime/src/main/java/org/apache/kafka/connect/converters/NumberConverter.java:
##########
@@ -122,5 +123,7 @@ public SchemaAndValue toConnectHeader(String topic, String 
headerKey, byte[] val
 
     @Override
     public void close() {
+        Utils.closeQuietly(this.serializer, "number format serializer");

Review Comment:
   What is `format`? Would `number converter serializer` or even just `number 
serializer` make more sense here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org