showuon commented on code in PR #12748:
URL: https://github.com/apache/kafka/pull/12748#discussion_r1034454065
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java:
##########
@@ -162,6 +162,28 @@ private boolean allSubscriptionsEqual(Set<String>
allTopics,
return isAllSubscriptionsEqual;
}
+ // visible for testing
+ MemberData memberDataFromSubscription(Subscription subscription) {
Review Comment:
> @showuon This method is getting less and less generic. Would it make sense
to push to version handling into `memberData` method? This would let each
assignor handle subscription v2 based on their specifics instead of having
those conditions here.
I agree it makes it much clear to move the version handling into
`memberData` method in each assignor. I've updated the PR. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
