[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

[GitBox]

showuon commented on code in PR #12748:
URL: https://github.com/apache/kafka/pull/12748#discussion_r1035600480


##########
clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java:
##########
@@ -44,14 +46,26 @@ public AbstractStickyAssignor createAssignor() {
     }
 
     @Override
-    public Subscription buildSubscription(List<String> topics, 
List<TopicPartition> partitions) {
-        return new Subscription(topics, assignor.subscriptionUserData(new 
HashSet<>(topics)), partitions);
+    public Subscription buildSubscriptionV0(List<String> topics, 
List<TopicPartition> partitions, int generationId) {
+        // cooperative sticky assignor only supports 
ConsumerProtocolSubscription V1 or above
+        return null;
     }
 
     @Override
-    public Subscription buildSubscriptionWithGeneration(List<String> topics, 
List<TopicPartition> partitions, int generation) {
-        assignor.onAssignment(null, new 
ConsumerGroupMetadata("dummy-group-id", generation, "dummy-member-id", 
Optional.empty()));
-        return new Subscription(topics, assignor.subscriptionUserData(new 
HashSet<>(topics)), partitions);
+    public Subscription buildSubscriptionV1(List<String> topics, 
List<TopicPartition> partitions, int generationId) {
+        assignor.onAssignment(new 
ConsumerPartitionAssignor.Assignment(partitions), new 
ConsumerGroupMetadata(groupId, generationId, consumer1, Optional.empty()));
+        return new Subscription(topics, assignor.subscriptionUserData(new 
HashSet<>(topics)), partitions, DEFAULT_GENERATION);
+    }
+
+    @Override
+    public Subscription buildSubscriptionV2Above(List<String> topics, 
List<TopicPartition> partitions, int generationId) {
+        return new Subscription(topics, null, partitions, generationId);

Review Comment:
   Yes, the user data is always provided, although we ignored. Updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org